Karl Fogel wrote:
> James Coleman <firstname.lastname@example.org> writes:
>> I'd like to submit a patch to the svn faq.
>> First patch submit (first post to dev!) so please forgive me if I'm making mistakes.
>> See attached add_svn_switch_issue_2505_to_faq.patch
>> For your convenience there is a copy of the patched faq.html here:
>> Add entry in FAQ for issue #2505: Why doesn't svn switch work in some cases?
>> * www/faq.html
>> Add svn switch question to index and add FAQ entry at end of Troubleshooting section.
>> Attached patch contains:
>> 1. FAQ entry in Troubleshooting (index entry and FAQ entry)
>> Why doesn't svn switch work in some cases?
>> Summary of problem and how to avoid the problem.
>> Examples of problem with errors seen and how to recover from the situation.
>> 2. Two other tiny errors in faq (internal links):
>> entry in FAQ TOC for #broken-subclipse was missing (nxt to new svn switch entry).
>> and found a href to #moderated that should be #moderation
>> I'm VERY sorry for including them in this patch but they really are tiny! :-7
> I think you forgot to attach the actual patch :-).
> But that's okay, I grabbed the full file.
> Please see r25732, r25733, r25734, r25735, and r25736, which show the
> importance of submitting logically separate changes as separate
> patches, each with their own log message. I did my best to untangle
> all the changes in this one patch, but (as you can see from the logs)
> I still messed it up, and had to make corrections later.
> I didn't want to ask you to resubmit this time, since you put so much
> work into writing the new FAQ entry already (thanks!). But please,
> next time, do follow the guidelines, they're there for a reason :-).
Again thanks for doing this and bearing with me!
I see from the logs you had some fun too :-7
Yes I will send patches individually if I do it again.
It would have been easier for me just to take a little extra time.
As two of the changes were right next to each other the second patch would have to
have included and be dependant on first patch.
It was taking me so long not alone getting faq entry right but also
writing emails. And in composing the faq entry and testing I found
out more about the problem and content of faq entry/emails had to
change more! :-P
To unsubscribe, e-mail: email@example.com
For additional commands, e-mail: firstname.lastname@example.org
Received on Mon Jul 16 12:35:16 2007