[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: augmented diff design patch format

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-06-26 11:54:23 CEST

On Mon, Jun 25, 2007 at 02:30:19PM -0700, Eric Gillespie wrote:
> "David Glasser" <glasser@mit.edu> writes:
>
> > The essential question in my view is: Is the ability to edit a patch
> > before applying it with "svn patch" valuable?
>
> I'm not sure about that particular case; i've heard it a few
> times, but only a few.
>

Agreed. I think the much more important use-case is...

> What is incredibly valuable (and common!) is reading a patch in
> email and doing code review by replying to the email. Do we
> really want to force people to send two attachments with the same
> data in different formats? I stand by my assertion that the
> second (tree-sensitive) format will simply not be there most of
> the time.
>

+1.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Tue Jun 26 11:54:24 2007

This is an archived mail posted to the Subversion Dev mailing list.