[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Move some of svn_types.h into svn_interfaces.h

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-06-24 00:10:56 CEST

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Glasser wrote:
> On 6/22/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>> Are there any objections to this approach, or suggestions for a better
>> one? Also, what are the backward compatibility implications of moving
>> other interface definitions in svn_types.h to svn_interfaces.h?
>
> Unless svn_types.h includes svn_interfaces.h, you probably can't move
> svn_log_message_receiver2_t from the former to the latter, since that
> would break code that just has "#include <svn_types.h>" and tries to
> use svn_log_message_receiver2_t.

svn_interfaces.h includes svn_types.h, not the other way around. We'd
start running into circular dependencies if we did it the other way, and
that's the problem that prompted this idea.

svn_log_message_receiver2_t was introduced as part of 1.5. As such, it
isn't yet part of the public API, and we don't have to maintain any
backward compat with it. We should be able to put it wherever we please
at this point. (After we release 1.5, it's stuck.)

However, your point does how for interface definitions which are
currently in svn_types.h

- -Hyrum
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGfZpwCwOubk4kUXwRAvKRAKDH2B9yH9Rs99neWmkXGGHg+DFxcgCfZepP
wmd5D04BohYcYA4iJxzSjbc=
=dGSv
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 24 00:06:50 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.