[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_status2 broken on trunk...

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-06-23 20:50:42 CEST

Lieven Govaerts wrote:
> Martin Hauner wrote:
>
>> Hi,
>>
>> the result of svn_client_status2 has changed from 1.4.4 to trunk.
>>
>> In subcommander i call svn_status_client2 with recurse false and all
>> true. This delivers all childeren of a dir including the folders. I
>> then do the recurse myself by calling status again non recursive on
>> each child folder (that way i don't have to wait for a complete
>> recursive status to finish before i can display something usefull in
>> the gui).
>>
>> Works fine until i build my code with the current trunk. On trunk an
>> svn_status_client2 call with recurse false and all true only delivers
>> the files only. No child folders anymore.
>>
>> Looks like the problem is the SVN_DEPTH_FROM_RECURSE macro:
>>
>> #define SVN_DEPTH_FROM_RECURSE(recurse) \
>> ((recurse) ? svn_depth_infinity : svn_depth_files)
>>
>> I guess replacing svn_depth_files with svn_depth_immediates would fix
>> it. I just don't know if it would be correct for all other uses of
>> that macro?
>>
>>
> No. status is the only command that interprets -N as 'this directory,
> its files and non-recursive subdirs'. If you check the code in
> subversion/svn/main.c line 1600 you'll notice that we work around this
> for the command line apps.
>
> We can solve this in svn_client_status2 for older svn clients, I'll make
> a patch tonight.
Martin,

can you validate that r25517 fixes your issue?

thanks for the report,

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 23 20:46:31 2007

This is an archived mail posted to the Subversion Dev mailing list.