[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svndumpfilter 1.4.4 (VC8 build) crash

From: Jens Peters <jpeters7677_at_gmx.de>
Date: 2007-06-21 20:00:14 CEST

Daniel Rall wrote:
> Your stack trace shows write_prop_to_stringbuf() choking. Do you have
> any interesting characters in your log messages? (It'd help to have
> the dump file to look at.)
>

Hello Daniel,

Thank you for asking. There aren't any special chars in the props and I can reproduce this crash with other dumpfiles as well. I do however took a
look at the trunk development of svndumpfilter and got curios about rev 23494.

[svndumpfilter: don't use '%n' in printf strings.

In VS2005, Microsoft has deprecated the use of %n as 'inherently
insecure' and turning it back on requires a special function call.

Suggested by: djh
               Jonathan Gilbert <o2w9gs702@sneakemail.com>

* subversion/svndumpfilter/main.c
   (write_prop_to_stringbuf, output_revision, output_node): Use the return
     value of sprintf() to determine how many characters were written, rather
     than using '%n' at the end of the string.]

After applying this revision to 1.4.4 everything works as expected with svndumpfilter build against libintl 0.14.6 VC8 build. So I would like to ask
if rev23494 can be backported to 1.4.x.

Regards,
Jens

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 21 20:01:30 2007

This is an archived mail posted to the Subversion Dev mailing list.