[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25447 - trunk/subversion/tests/cmdline/svntest

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-06-20 19:35:24 CEST

On Mon, 18 Jun 2007, lgo@tigris.org wrote:
...
> Fix issue where failed tests on Windows don't return errorlevel > 0.
>
> * subversion/tests/cmdline/svntest/main.py
> (SpawnTest.run): the exitcode of a spawned process on Windows will not be
> correct, so check for patterns of type 'FAIL: ' on stdout of the process.
...
> --- trunk/subversion/tests/cmdline/svntest/main.py (original)
> +++ trunk/subversion/tests/cmdline/svntest/main.py Mon Jun 18 11:55:24 2007
> @@ -806,8 +806,11 @@
>
> self.result, self.stdout_lines, self.stderr_lines =\
> spawn_process(command, 1, None, *args)
> - sys.stdout.write('.')
> + # don't trust the exitcode, will not be correct on Windows
> + if filter(lambda x: x[:6] == 'FAIL: ', self.stdout_lines):
> + self.result = 1
> self.tests.append(self)
> + sys.stdout.write('.')

How about x.startswith('FAIL: ') instead?

  • application/pgp-signature attachment: stored
Received on Wed Jun 20 19:35:28 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.