Re: Adding empty files: change to svn_fs_make_file and documentation for the delta editor?

On Tue, Jun 19, 2007 at 04:38:10PM -0400, David Glasser wrote:
> he used some external tool). In my opinion, the bug is that the
> revision exists with a "false" text_mod. This can be fixed by
> patching the implementations of svn_fs_make_file in both filesystems
> to set text_mod to true for newly-created (non-copied) file nodes. I
> think we should do this. This should guarantee that new empty files
> (created through commits, loads, or direct svn_fs_* calls) always have
> text_mod set to TRUE.

Ouch. +1, sure.

> Additionally, given that the neon and serf commit editor
> implementations assume that apply_textdelta will be called on new
> empty files (which the libsvn_client commit driver always does, as
> will the repos_replay commit driver if the revision isn't broken as
> above in the first place), we should change the documentation of the
> delta editor to explicitly state that apply_textdelta is required for
> all new (uncopied) files.

I don't like this. Isn't this arguably a bug in ra_{serf,neon}? If I
call

  add_file
  close_file

Then I expect the file to exist. That the Neon and Serf commit editors
drop the file on the floor looks like a bug to me.

> - svn_fs_path_change_add, 0, 0, trail, trail->pool));
> + svn_fs_path_change_add, 1, 0, trail, trail->pool));
>

(The 1's and 0's should probably be TRUE and FALSE - they're booleans.)

Regards,
Malcolm