[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add size information to svn_client_info()

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-06-16 23:56:52 CEST

"David Glasser" <glasser@mit.edu> writes:
> This seems like good information to have. A few comments about the patch:
>
>> [[[
>> Make svn_client_info() return the size or working size of a file or
>> folder too since this information is already available and comes at no
>> cost.
>>
>> subversion/include/svn_client.h : add members working_size and size to
>> the svn_info_t struct and document
>> them.
>> subversion/libsvn_client/info.c : provide the working size and size
>> information to the caller.
>> ]]]
>
> Please follow our standards for writing log messages, especially
> including the names of the modified functions.

Agree with the sentiment, but to save Stefan some time, here's a
rewrite of the log message:

[[[
Make svn_client_info() return the size or working size of a file or
folder too since this information is already available and comes at no
cost.

* subversion/include/svn_client.h
  (struct svn_info_t): Add members working_size and size.

* subversion/libsvn_client/info.c
  (build_info_from_dirent): Adjust accordingly.
]]]

HTH,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 16 23:57:09 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.