[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25365 - trunk/subversion/libsvn_repos

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-06-12 17:01:39 CEST

Paul Burba wrote:
>> -----Original Message-----
>> From: hwright@tigris.org [mailto:hwright@tigris.org]
>> Sent: Monday, June 11, 2007 4:30 PM
>> To: svn@subversion.tigris.org
>> Subject: svn commit: r25365 - trunk/subversion/libsvn_repos
>>
>> Author: hwright
>> Date: Mon Jun 11 13:29:57 2007
>> New Revision: 25365
>>
>> Log:
>> Add some iteration pools to improve memory usage.
>>
>> * subversion/libsvn_repos/log.c
>> (do_logs, svn_repos_get_logs4): Add and use some iterpools.
>>
>>
>> Modified:
>> trunk/subversion/libsvn_repos/log.c
>>
>> Modified: trunk/subversion/libsvn_repos/log.c
>> URL:
>> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_repos
>> /log.c?pathrev=25365&r1=25364&r2=25365
>> ==============================================================
>> ================
>> --- trunk/subversion/libsvn_repos/log.c (original)
>> +++ trunk/subversion/libsvn_repos/log.c Mon Jun 11 13:29:57 2007
>> @@ -1026,12 +1026,14 @@
>
> <snip>
>
>> @@ -1170,6 +1175,7 @@
>> {
>> int send_count = 0;
>> int i;
>> + apr_pool_t *iterpool = svn_pool_create(pool);
>>
>> /* They want history for the root path, so every rev
>> has a change. */
>> send_count = hist_end - hist_start + 1; @@ -1178,6 +1184,8 @@
>> for (i = 0; i < send_count; ++i)
>> {
>> struct log_tree_node *tree;
>> +
>> + svn_pool_clear(iterpool);
>> svn_revnum_t rev = hist_start + i;
>>
>> if (descending_order)
>> @@ -1187,9 +1195,11 @@
>
>
> Hi Hyrum,
>
> Just a quick fyi -- The statement clearing the iterpool prior to the
> svn_revnum_t rev declaration is fine per the C99 standard, but it's
> illegal syntax on Visual Studio 2005 which supports the C89 standard (or
> at least isn't fully C99 compliant - I'm not sure which). I fixed in
> r25377.

Bah. Thanks, Paul. +1 on being C89 compliant. I missed the
declaration part of that statement when adding the call to
svn_pool_clear(). Thanks for fixing it.

-Hyrum

Received on Tue Jun 12 17:01:59 2007

This is an archived mail posted to the Subversion Dev mailing list.