RE: [PATCH] remove redundant code

> -----Original Message-----
> From: Daniel Rall [mailto:dlr@collab.net]
> Sent: Monday, June 11, 2007 4:56 PM
> To: Kamesh Jayachandran
> Cc: Paul Burba; Malcolm Rowe; SVN Dev
> Subject: Re: [PATCH] remove redundant code
>
> On Fri, 06 Apr 2007, Kamesh Jayachandran wrote:
>
> > Nice point Paul.
> >
> > Yes this patch breaks the existing behaviour.
> >
> > But won't it be good to move this snippet of code(with a
> > better comment) from svn binary to libsvn_client(as suggested
> > by Malcom) so that other client implementation would be free
> > from having this code.
>
> Moving this code to libsvn_client/merge.c seems like a good
> idea. I still see it in merge-cmd.c.

I have no objections to this part of the change, excepting what I noted
here:

http://svn.haxx.se/dev/archive-2007-04/0292.shtml
http://svn.haxx.se/dev/archive-2007-04/0355.shtml

(Maybe that isn't even a problem?)

I'd even do this myself, but I don't quite see where exactly in
libsvn_client to make the change.

> Was another patch ever submitted?
 
Not that I could find.

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 12 15:57:21 2007