Revert r23264 for the sake of zsh?

I finally got some time this evening to track down one of my major
annoyances with Subversion - and I finally figured it out after a
couple of attempts over a period of several months as to what's going
wrong.

With 1.5 (trunk), tab completion doesn't work - I get:

% svn diff <TAB>
_arguments:comparguments:208: invalid argument: ARG

This pretty much happens for every subcommand. On a whim, I tried
1.4.3 and it worked fine - that was the missing bit I hadn't tried
before. I tracked it down to the fact that zsh is looking for 'arg'
literal in our help output as a magic string - it's not case
sensitive.

The culprit revision on our end is:

---
r23264 | nori | 2007-01-26 19:31:07 -0800 (Fri, 26 Jan 2007) | 6 lines
Make all the command line option arguments written in uppercase as "ARG".
* subversion/libsvn_subr/opt.c (svn_opt_format_option):
* subversion/svnserve/main.c (svnserve__options):
  Make "arg" uppercase.
---
Anyone know what the rationale for this was?  The fact that it
absolutely kills zsh is *very* annoying and I view this as a
regression compared to 1.4.  While zsh could (should) fix it upstream,
getting the update so that tab completion works distributed to
everyone is going to be a giant PITA if we leave it to OS vendors,
etc.  What was the compelling need for this change?
Thoughts on reverting?
Oh, a hacky zsh fix is to apply the following patch to the _subversion
completion function file (i.e. replace 'arg' with 'ARG'):
http://people.apache.org/~jerenkrantz/svn-zsh-complete.patch  (Either
patch the distributed _subversion file or plop a new one in a
directory and point fpath to it before compinit is invoked.)  There
probably is a way to get it to do with case-sensitivity - I don't care
to delve into that at the moment for my own needs.
I'm now glad that I figured it out and I can use tab completion again.
 =)  -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org