On 6/3/07, Martin Hauner <martin.hauner@gmx.net> wrote:
> Hi,
>
> Mark Phippard wrote:
> > I think we really need to address the problems of APR ICONV in our
> > next release. Please see this thread for some references:
> >
> > http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=582337
> >
> >
> > This library has always been a problem, when there are multiple
> > clients installed and they used different compilers. But now with a
> > mixture of APR ICONV 0.9.x and 1.1.x out there this problem is going
> > to escalate. It crashes Subversion, which means it can also crash
> > clients using Subversion.
>
> I'm simply applying a small patch (already sent to the list, this is a
> recurring issue ;) that makes apr iconv first look into a subfolder iconv
> that is in the same dir as the libapriconv.dll.
>
> I'm doing this for years now and I have never seen any problems with it
> having svn, tsvn and subcommander on my system.
>
> I think Stefan used a similar patch in the past. I don't know why he
> changed it.
>
> Since subcommander/submerge is using the same iconv based code on
> Unix/Windows i'm not in favour of removing apr-iconv on Windows.
I look at it differently. On every platform except Windows, we are
using the iconv library from the OS. On Windows we require apr-iconv,
and the 200+ extra libraries that drags along with it. There is also
no precedent for Subversion applying a patch to a third party library
as part of its build process. Sure you can do it for your product,
but Subversion is not likely going to do it for the binaries it
releases. There are already many reports on the users@ list of
crashes because of the incompatabilities.
I think that using the translation services provided by Windows makes
us more consistent in our approach and also makes our app easier to
distribute as well as more robust in that it will not be as prone to
crashes.
The patch you talk about has been around for years and for whatever
reason the apr-iconv maintainers have chosen not to apply it. I think
it is time to look for an alternative.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 3 18:15:09 2007