[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] bash_completion: propose file names for few commands

From: Fabien COELHO <fabien_at_coelho.net>
Date: 2007-06-03 15:10:51 CEST

A few questions and comments about your last submission,

(1) is the vim line added at the top of the file really necessary?

(2) why do you use the -v option for del and log?

(3) I'm unsure about whether to use -b or -c for cut.
     ISTM that we're dealing with characters here?
     Maybe that would not change anything.

(4) maybe the structure could be factored out so that there is only
     one line with the svn call, something like:

     local FILES=$(svn ls $some_options | grep $something | cut -c8)
     COMPREPLY=( ... )

     Well that does not seem to work with the last case.

(5) there is no documentation about the environment variables.

(6) after thinking it over, and due to the various other patches
     that have been submitted in the past, I think that some
     generic variable would make sense. Some people
     want to have "svn ls" for instance to gather choices.

     Tests may look like:

     if [[ $SVN_BASH_OPTIONS == *url-ext* ]] ...
     if [[ $SVN_BASH_OPTIONS == *local-file-ext* ]] ...
     if [[ $SVN_BASH_OPTIONS == *local-file-recursive* ]] ...

(7) You tested with a polish locale, including UTF8. Good.
     Did the file names use non-ascii characters in these tests?

-- 
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 3 15:11:19 2007

This is an archived mail posted to the Subversion Dev mailing list.