[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_load_dirs.pl: execute bit on files triggers an "add"

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-06-03 04:07:11 CEST

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ping...
This patch has been out there for a while, but hasn't had any comments.
 If there are none in the next few days, I'll open an issue.

- -Hyrum

Mark Reibert wrote:
> Hello,
>
> svn_load_dirs.pl will set "svn:executable" on any executable plain file,
> even those that have not changed (MD5). This triggers the file to be
> processed as an addition to the repository and copied from the import
> directory into the staging working copy. This behavior seem
> unintentional (or at least inconsistent) since all other properties (via
> the -p option) are set only for newly added files. More importantly, it
> will trigger a failure if the target in the staging working copy is
> read-only. (That issue coming in another post.)
>
> [[[
> * contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in
> Set "svn:executable" only for newly added (executable) files.
> ]]]
>
>
>
> ------------------------------------------------------------------------
>
> Index: contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in
> ===================================================================
> --- contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in (revision 24000)
> +++ contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in (working copy)
> @@ -991,17 +991,17 @@
> last if $property->{control} eq 'break';
> }
> }
> - }
>
> - # Add svn:executable to files that have their executable bit
> - # set.
> - if ($source_is_exe)
> - {
> - print "Adding to '$source_path' property 'svn:executable' with ",
> - "value '*'.\n";
> - my $property = {name => 'svn:executable', value => '*'};
> - push (@{$add_files{$source_path}{properties}},
> - $property);
> + # Add svn:executable to files that have their executable bit
> + # set.
> + if ($source_is_exe)
> + {
> + print "Adding to '$source_path' property 'svn:executable' with ",
> + "value '*'.\n";
> + my $property = {name => 'svn:executable', value => '*'};
> + push (@{$add_files{$source_path}{properties}},
> + $property);
> + }
> }
>
> # Now make sure the file or directory in the source directory
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGYiJPCwOubk4kUXwRAnz5AKD23wpUZ96P7H5AuxAuoFi8fk/KcwCfUa+d
q8lZ80ZozT5dAfCF8ryq+0c=
=ZL4M
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 3 04:04:31 2007

This is an archived mail posted to the Subversion Dev mailing list.