On 6/2/07, D.J. Heap <djheap@gmail.com> wrote:
> On 5/30/07, Mark Phippard <markphip@gmail.com> wrote:
> > I think we really need to address the problems of APR ICONV in our
> > next release. Please see this thread for some references:
> >
> > http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=582337
> >
> > This library has always been a problem, when there are multiple
> > clients installed and they used different compilers. But now with a
> > mixture of APR ICONV 0.9.x and 1.1.x out there this problem is going
> > to escalate. It crashes Subversion, which means it can also crash
> > clients using Subversion.
> >
> > Stefan King did the work of creating an initial patch that replaces
> > the dependency with Win32 API's. I think we just need some consensus
> > that this is what we should do, and then get a developer to do it.
> >
> > I think this is important and we are going to have problems if we do
> > not address this for 1.5.
> >
>
>
> I would love to see this go in as well. Using an unpatched apr-iconv
> on Windows is problematic at best, due to the global environment
> variable (as has been explained already).
>
> Unfortunately, I don't know much about multi-language issues and so
> I'm not sure I can help much. But I am very much for using Stefan's
> implementation if it works well, and I will help build and test where
> I can.
Great. It sounds like there is general consensus that this would be a
good improvement, assuming we can make the code work.
Have you seen the patches Stefan previously submitted?
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=106781
Perhaps that could be a starting point. Not sure if the patch still
applies cleanly.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 2 17:18:29 2007