[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SASL for ra_svn on Windows

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-06-01 02:08:04 CEST

On Sat, 26 May 2007, Vlad Georgescu wrote:

> Stefan Küng wrote:
> > D.J. Heap wrote:
> >> On 5/26/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> >> [snip]
> >>> That would help, yes. But still not solve the problem: sasl would still
> >>> search the plugins in all the registered paths.
> >>
> >> Hmm, you mean the set_path call just adds that path to the front of
> >> the search list -- it would still search the default install for
> >> plug-ins?
> >
> > I haven't checked the whole source of SASL, but from what I've seen I'd
> > have to say yes. I'm not even sure if set_path will add the path to the
> > front of the list - it could even add the path to the back of that list.
> > I think I'll go with my patch instead, that way I'm sure that the other
> > paths are ignored.
> >
>
> Looking at the Cyrus SASL 2.1.22 sources (specifically the lib/common.c
> file), once you call sasl_set_path() it changes the default path
> callback from _sasl_getpath() (which looks into the registry) to
> _sasl_getpath_simple(), which will simply return the value you provided.
> So it shouldn't look into any other paths than the one you explicitly set.

Good news! This sounds pretty safe -- static linkage doesn't seem
necessary, so long as no one is overwriting your Subversion-specific
SASL DLLs.

  • application/pgp-signature attachment: stored
Received on Fri Jun 1 02:09:07 2007

This is an archived mail posted to the Subversion Dev mailing list.