[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: svn commit: r25204 - trunk/subversion/tests/cmdline

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-05-31 17:28:45 CEST

On Thu, May 31, 2007 at 11:16:05AM -0400, David Glasser wrote:
> On 5/30/07, Paul Burba <pburba@collab.net> wrote:
> > > -----Original Message-----
> > > From: Malcolm Rowe [mailto:malcolm-svn-dev@farside.org.uk]
> > > chdir() calls should be inside a try/finally block so that an
> > > exception inside won't break the rest of the tests (due to
> > > failure to reset the cwd).
>
> > I made this one change (r25225) mentioned by Malcolm as I added a new
> > merge test today. Without this change my test, which comes after
> > copy_src_detection_bug_if_target_has_many_ancestors_in_same_commit() in
> > the test_list, fails.
>
> Hmm. Could we just put cwd save/reset into the test driver, and
> delete all of the repetitive try/finally blocks in the tests?
>

Yes, that would seem like a much more sensible option. We'd still need
to save/restore the cwd in a few places, but most would simply become
os.chdir('foo').

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Thu May 31 17:29:04 2007

This is an archived mail posted to the Subversion Dev mailing list.