[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25206 - trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-05-31 17:09:57 CEST

On 5/31/07, David Glasser <glasser@mit.edu> wrote:
> On 5/30/07, blair@tigris.org <blair@tigris.org> wrote:
> > Author: blair
> > Date: Wed May 30 11:32:51 2007
> > New Revision: 25206
> >
> > Log:
> > [ in subversion/bindings/javahl/ ]
> >
> > * src/org/tigris/subversion/javahl/NativeResources.java:
> > Style tweak, use 'if (null == X)' instead of 'if (X == null)'.
>
> This seems unnecessary, since 'if (X = null)' is not legal in Java.

+1

This is guarding against a problem that cannot happen and is not
standard for any code style I have seen. I greatly prefer the other
style.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 31 17:10:09 2007

This is an archived mail posted to the Subversion Dev mailing list.