[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: svn commit: r25204 - trunk/subversion/tests/cmdline

From: Paul Burba <pburba_at_collab.net>
Date: 2007-05-31 03:01:11 CEST

> -----Original Message-----
> From: Malcolm Rowe [mailto:malcolm-svn-dev@farside.org.uk]
> Sent: Wednesday, May 30, 2007 12:36 PM
> To: dev@subversion.tigris.org; kameshj@tigris.org
> Subject: Re: svn commit: r25204 - trunk/subversion/tests/cmdline

<snip>

> > + svntest.actions.run_and_verify_commit(wc_dir, expected_output,
> > + expected_status, None,
> > + None, None, None, None,
> > + wc_dir) saved_cwd = os.getcwd()
> > + os.chdir(A_copy_of_B_C_path)
>
> chdir() calls should be inside a try/finally block so that an
> exception inside won't break the rest of the tests (due to
> failure to reset the cwd).

Hi Kamesh,

I made this one change (r25225) mentioned by Malcolm as I added a new
merge test today. Without this change my test, which comes after
copy_src_detection_bug_if_target_has_many_ancestors_in_same_commit() in
the test_list, fails.

My new test is currently Xfail but I'm about to commit the fix and don't
want the buildbots failing.

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 31 03:01:49 2007

This is an archived mail posted to the Subversion Dev mailing list.