[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Why do we store svn config section options in a caseinsensitive way?

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-05-23 19:08:27 CEST

On Tue, 22 May 2007, Kamesh Jayachandran wrote:

> >+1. Given the inability to have different rules for differently-cased
> >versions of a filename, I don't see why we shouldn't ignore case when
> >determining the applicability of an autoprop rule too.
> >
> >Regards,
> >Malcolm
>
>
> Thanks all. Attaching the patch in the direction suggested by Justin.

I'm in favor of this change. Kamesh's patch looks good, but I think
it needs a companion change like this to indicate in the
auto-generated config file that auto-props are applied
case-insensitively:

Index: subversion/libsvn_subr/config_file.c
===================================================================
--- subversion/libsvn_subr/config_file.c (revision 25117)
+++ subversion/libsvn_subr/config_file.c (working copy)
@@ -984,9 +984,10 @@
         "### The format of the entries is:" NL
         "### file-name-pattern = propname[=value][;propname[=value]...]" NL
         "### The file-name-pattern can contain wildcards (such as '*' and" NL
- "### '?'). All entries which match will be applied to the file." NL
- "### Note that auto-props functionality must be enabled, which" NL
- "### is typically done by setting the 'enable-auto-props' option." NL
+ "### '?'). All entries which match (case-insensitively) will be" NL
+ "### applied to the file. Note that auto-props functionality" NL
+ "### must be enabled, which is typically done by setting the" NL
+ "### 'enable-auto-props' option." NL
         "# *.c = svn:eol-style=native" NL
         "# *.cpp = svn:eol-style=native" NL
         "# *.h = svn:eol-style=native" NL

Kamesh, +1 to commit your patch along with something like the above.

- Dan

  • application/pgp-signature attachment: stored
Received on Wed May 23 19:08:39 2007

This is an archived mail posted to the Subversion Dev mailing list.