[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24791 - in trunk/subversion/bindings/javahl: native src/org/tigris/subversion/javahl src/org/tigris/subversion/javahl/tests

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-05-02 01:53:01 CEST

On Tue, 01 May 2007, Mark Phippard wrote:

> On 5/1/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
> >
> >The attached patch uses a byte array instead of a String to move the
> >property values from the Java layer to the C++ layer. I have a little
> >misgiving about using a ClientException, but I don't see a better way to
> >implement the error handling when specifying the UTF-8 encoding.
>
> I have only loosely followed this thread and do not really understand
> the C++ code enough to comment. But stepping back, we had two methods
> that presumably worked and did roughly the same thing. We wanted to
> apparently consolidate the C++ code to a single method. If both of
> the previous methods worked correctly than what is the complication
> here in terms of the encoding?
>
> In general I am just concerned when we are taking working code and
> changing it to eliminate redundancy but are not 100% sure we are not
> now adding problems.

I am unconvinced that the previous code actually worked for multi-byte
character encodings.

  • application/pgp-signature attachment: stored
Received on Wed May 2 01:53:13 2007

This is an archived mail posted to the Subversion Dev mailing list.