[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Should --pre-1.4-compatible imply --pre-1.5-compatible?

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-04-28 01:25:23 CEST

Seems to me it should. I feel like a dope typing 'svnadmin
create --pre-1.4-compatible --pre-1.5-compatible'. How about
this patch? The alternative is to check both config values
everywhere, but that seems hairy...

[[[
* subversion/svnadmin/main.c
  (subcommand_create): Make --pre-1.4-compatible imply --pre-1.5-compatible.
]]]

Index: subversion/svnadmin/main.c
===================================================================
--- subversion/svnadmin/main.c (revision 24819)
+++ subversion/svnadmin/main.c (working copy)
@@ -521,7 +521,7 @@
                  APR_HASH_KEY_STRING,
                  "1");
 
- if (opt_state->pre_1_5_compatible)
+ if (opt_state->pre_1_4_compatible || opt_state->pre_1_5_compatible)
     apr_hash_set(fs_config, SVN_FS_CONFIG_PRE_1_5_COMPATIBLE,
                  APR_HASH_KEY_STRING,
                  "1");

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 28 01:26:32 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.