[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24612 - trunk/subversion/bindings/javahl/native

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-04-17 22:46:39 CEST

blair@tigris.org wrote:
> Author: blair
> Date: Tue Apr 17 13:32:49 2007
> New Revision: 24612
>
> Log:
> * subversion/bindings/javahl/native/*.{h,cpp}:
> Formatting clean up:
> Start comment sentences with capital letters.
> Do not use inline comments.
> Wrap to 80 characters.
> Add vertical whitespace between functions and methods,
> preprocessor macros.
> Remove comments on constructor and destructors where the comment
> was "this is a constructor" or "this is a destructor".

Blair,
Thanks for the much needed cleanups. It seems that lots of comments that
were already under 80 characters per line were wrapped even farther. Is
there a reason for this?

Thanks,
-Hyrum

> Modified: trunk/subversion/bindings/javahl/native/BlameCallback.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native/BlameCallback.h?pathrev=24612&r1=24611&r2=24612
> ==============================================================================
> --- trunk/subversion/bindings/javahl/native/BlameCallback.h (original)
> +++ trunk/subversion/bindings/javahl/native/BlameCallback.h Tue Apr 17 13:32:49 2007
> @@ -25,12 +25,13 @@
> #if _MSC_VER > 1000
> #pragma once
> #endif // _MSC_VER > 1000
> +
> #include <jni.h>
> #include "svn_client.h"
>
> /**
            1 2 3 4 5 6 7 8
   12345678901234567890123456789012345678901234567890123456789012345678901234567890
> - * This class holds a Java callback object, which will receive every line of
> - * the file for which the callback information is requested.
> + * This class holds a Java callback object, which will receive every
> + * line of the file for which the callback information is requested.
> */
> class BlameCallback
> {
> @@ -53,9 +54,10 @@
>
> private:
> /**
> - * this a local reference to the Java object.
> + * This a local reference to the Java object.
> */
> jobject m_callback;
> };
> +
> // !defined(AFX_BLAMECALLBACK_H__3BBF3F0F_C80C_45C9_8AC3_E1AF07E5B810__INCLUDED_)
> #endif
...

Received on Tue Apr 17 22:45:23 2007

This is an archived mail posted to the Subversion Dev mailing list.