[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] URL completion in bash_completion

From: Kylo Ginsberg <kylo.ginsberg_at_gmail.com>
Date: 2007-04-16 21:36:02 CEST

On 4/16/07, C. Michael Pilato <cmpilato@collab.net> wrote:
> Kylo Ginsberg wrote:
> > I saw a thread a few weeks back which included a patch for URL
> > completion. I took that patch and ran a little farther with it,
> > adding:
> > * works for http or svn URLs
> > * add completion for partial elements
> > * if available, uses the COMP_WORDBREAKS feature in bash for cleaner
> > results
> >
> > This patch is not submission-ready (at least) because it shares flaws
> > pointed out in the previous patch:
> > * uses sed
> > * doesn't try to handle authentication
>
> I dunno what to do about 'sed', but I think this stuff should just be
> passing --non-interactive to the 'svn' command and punting on
> authentication. If the auth creds aren't already in the user's local cache,
> it's just their loss.

Good call on using --non-interactive. I attached a second version of
the patch which:
* uses --non-interactive
* conforms to the (general) usage of tabs for white space in the file
* adds "-o nospace" to the invocation of bash "complete"

That last might well be disputed, but in my usage, it's a greater evil
to have to backspace the extra space at each level in a url completion
than to add the space after each argument.

Kylo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Apr 16 21:36:11 2007

This is an archived mail posted to the Subversion Dev mailing list.