[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] ABI Breakage in r22674: svn_client_ctx_t

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-04-05 18:33:29 CEST

On Thu, 05 Apr 2007, Garrett Rooney wrote:

> On 4/5/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> >On Thu, Apr 05, 2007 at 12:21:26PM +0200, Bert Huijben wrote:
> >> Commit r22674 introduced 2 new members in svn_client_ctx_t for subversion
> >> 1.5 before existing 1.3 members, which changed the in memory
> >representation
> >> of the binary API.
> >> (New members should only be introduced at the end of this structure
> >before
> >> 2.0)
> >>
> >
> >This seems correct, though I haven't tested it. While we require that
> >users allocate the structure via svn_client_create_context() (so that we
> >can add fields to it), we allow direct access to the structure once
> >allocated - so we can't add new fields except at the end.
>
> That is correct, they should be moved before 1.5 is released.

Thanks Bert (and Malcolm and Garrett for the review). I've committed
Bert's patch to trunk in r24449.

- Dan

  • application/pgp-signature attachment: stored
Received on Thu Apr 5 18:34:17 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.