Re: [PATCH] Make fsfs survive stale NFS file handles
From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-04-05 14:31:32 CEST
On Wed, Apr 04, 2007 at 12:03:08PM -0700, Eric Gillespie wrote:
(Note that we don't support NFSv2 locking, which typically means that we
> + * You must initialize err to SVN_NO_ERROR, as these macros will never
(You must also initialise it to SVN_NO_ERROR because otherwise the
> +#define SVN_IGNORE_ESTALE(err, expr) \
I was going to say that this leaks err, when ESTALE, except that I see
Reasoning about the behaviour of these macros is pretty hard, though,
> +/* Long enough to hold: "<svn_revnum_t> <node id> <copy id>\0"
That's 10 bytes for a long, 19 bytes would be for a hypothetical 64-bit
> + Allocations are performed from POOL. */
"performed in" is the normal terminology.
The rest of the patch looks fine.
This is an archived mail posted to the Subversion Dev mailing list.