[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24342 - trunk/subversion/include

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-04-03 17:46:25 CEST

On Tue, 03 Apr 2007, Peter Lundblad wrote:

> dlr@tigris.org writes:
...
> > - * @a path_or_url is a WC path or repository URL. @a revision is the
> > - * revision at which to get @a path's merge info.
> > + * @a path_or_url is a WC path or repository URL. If @a path_or_url
> > + * is a WC path, @a revision is ignored in preference to @a
> > + * path_or_url's @c BASE revision. If @a path_or_url is a URL, @a
>
> AFAICT from the code, this is WORKING, not BASE, right?

As we're referring to a revision number, the number for WORKING and
BASE are identical. At the time I thought saying BASE would make this
more clear, but I really don't feel strongly about it.
 
> > + * revision is the revision at which to get its merge info. @a
> > + * mergeinfo and any temporary allocations are made in @a pool.
 
> Well, that sentence sounds wrong to me "mergeionf is made in @a pool"... ;)
> We don't need to mention that temp allocations are made in the pool, just
> that the return value is.

Okay, will fix.

  • application/pgp-signature attachment: stored
Received on Tue Apr 3 17:46:51 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.