Hi,
In <ae6cb1100704021142t1c10a7fegfbd853739e2a1f63@mail.gmail.com>
"Re: [patch] add copying of bdb and sqlite dlls to win-tests.py" on Mon, 2 Apr 2007 11:42:55 -0700,
"Joe Swatosh" <joe.swatosh@gmail.com> wrote:
> > > I tried out the zip this morning. I was able to run all the tests
> > > except the client tests with nothing but the windows directories and
> > > ruby on my path after I copied
> > >
> > > sqlite3.dll
> > > intl3_svn.dll
> > > libdb44.dll
> > >
> > > into the ext directory. After I put my current subversion on the
> > > path, I was able to run the client tests too. I'm not completely sure
> > > how the bindings are supposed to opperate. Should they be completely
> > > stand-alone, or should we assume a installation of SVN on the path? I
> > > think the only reason I needed to add SVN to the path to get the
> > > client tests working was for the tests (needs a svnserve).
> >
> > I want the zip to work stand-alone. But users that uses the
> > zip don't run tests. So, I think that we don't need to put
> > the DLLs into the zip.
> >
>
> I just ran the tests against the zip stuff to see how it would work.
> I agree that users won't need to run the tests, however if the zip is
> to be stand alone I think it will need those files.
I changed my thought. We should include all DLLs. What about
attached patch?
Thanks,
--
kou
Index: build/win32/make_dist.py
===================================================================
--- build/win32/make_dist.py (revision 24376)
+++ build/win32/make_dist.py (working copy)
@@ -273,7 +273,13 @@
FileGlob('%(blddir)s/libsvn_*/*.dll'),
File('%(@apr)s/%(aprrel)s/libapr.dll'),
File('%(@apr-iconv)s/%(aprrel)s/libapriconv.dll'),
- File('%(@apr-util)s/%(aprrel)s/libaprutil.dll')),
+ File('%(@apr-util)s/%(aprrel)s/libaprutil.dll'),
+ File('%(@berkeley-db)s/bin/libdb%(bdbver)s.dll'),
+ OptFile('%(@openssl)s/out32dll/libeay32.dll'),
+ OptFile('%(@openssl)s/out32dll/ssleay32.dll'),
+ OptFile('%(@libintl)s/bin/intl3_svn.dll'),
+ File('%(@neon)s/libneon.lib'),
+ OptFile('%(@zlib)s/zlibstat.lib')),
'share': None,
'share/locale': InstallMoFiles('%(srcdir)s/%(svnrel)s/mo'),
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 3 13:35:28 2007