[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_fs_util: New library to reuse FSFS and BDBfunctions

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-04-02 14:09:02 CEST

On Mon, Apr 02, 2007 at 04:55:43PM +0530, Bhuvaneswaran Arumugam wrote:
> List of redundant functions in libsvn_fs_fs/dag.c &
> libsvn_fs_base/dag.c:

Some of these functions need access to the per-fs dag_node_t type, so
can't be shared.

> List of redundant functions in libsvn_fs_fs/err.c &
> libsvn_fs_base/err.c:

(Incidentally, these might be better as macros - so that the line number
of the caller is reported. I don't know what anyone else thinks).

> List of redundant functions in libsvn_fs_fs/id.c & libsvn_fs_base/id.c:

These need access to the id_private_t type, which isn't shared between
FSFS and BDB.

> List of redundant functions in libsvn_fs_fs/lock.c &

I'm actually suprised that the entire locking subsystem isn't shared -
isn't the implementation absolutely identical?

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Mon Apr 2 14:09:23 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.