Re: [PATCH] libsvn_fs_fs: The file system check function should beconsistent

On Mon, Apr 02, 2007 at 04:09:56PM +0530, Bhuvaneswaran Arumugam wrote:
> In FSFS file system check function, svn_fs_fs__check_fs(), we check for
> fs->path variable, while in the BDB counterpart, svn_fs_base__check_fs()
> function we check for fs->fsap_data variable to check the file system.
>

I do wonder whether there's actually any benefit to these checks at all,
given that the only way a caller [1] could trigger them would be to call
svn_fs_new() directly, and even then, the cause'd be pretty obvious even
if we didn't have the check.

[1] Other than fs-loader.c, which I'd argue is trivially verifiable by
eye.

But <shrug>, +1 to commit, assuming you've tested it.

Regards,
Malcolm