[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] for sh portability issue in davautocheck.sh

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2007-03-29 02:49:12 CEST

Peter Samuelson wrote:
> [Max Bowsher]
>> So long as the script say "#!/bin/bash", it's not even _trying_ to be
>> portable - there's no point trying to enhance the portability, if the
>> script declares that it is not portable.
>
> Which is why r24218 is purely cosmetic. [ ] is a builtin in bash, as
> in all modern shells. I think my followup patch removes all bashisms,
> but as I said at the time, I didn't attempt to remove the use of the
> less-than-perfectly-portable ldd program.

Fortunately ldd is used only as a way to fail earlier in a particular
error scenario - it's not actually required for the tests to work.

Actually, due to a quirk of the way the script is written, it continues
fine even if ldd is not found.

Max.

Received on Thu Mar 29 02:49:27 2007

This is an archived mail posted to the Subversion Dev mailing list.