[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking]copy_tests 11 fails over ra_dav

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-03-27 21:47:00 CEST

On Tue, 27 Mar 2007, Kamesh Jayachandran wrote:

> Daniel Rall wrote:
> >Kamesh, this works great! I noticed that it doesn't use the RA
> >session reparenting suggested by Peter Lundblad -- any particular
> >reason for that?
> Yes. After sending the patch last week, I thought of trying reparent
> api, but could not do so.
>
> Yes, reparenting is the way to go.
>
> Find the attached patch.

Thanks Kamesh, I'll take a look.

> >Also, there's some error handling in
> >get_implied_merge_info() to account for locally-added but uncommitted
> >versioned resources; is it still correct as written (e.g. do we still
> >need the test for SVN_ERR_RA_DAV_REQUEST_FAILED)? Seems a little odd
> >
> Yes we still need this.
> In this case ra_dav layer returns 'SVN_ERR_RA_DAV_PATH_NOT_FOUND' not
> 'SVN_ERR_RA_DAV_REQUEST_FAILED'.
>
> >that there's no special-casing for ra_svn's protocol.
> >
> ra_svn returns SVN_ERR_FS_NOT_FOUND like ra_local. So no need to special
> case.

I wonder if there's a way to smuggle that same error code back to the
client over DAV?

  • application/pgp-signature attachment: stored
Received on Tue Mar 27 21:47:21 2007

This is an archived mail posted to the Subversion Dev mailing list.