Re: [PATCH] hot-backup archiving failes on Windows because of read-only files

On 3/18/07, Jens Peters <jpeters7677@gmx.de> wrote:
> > I unfortunately don't have time to review the patch itself, but for
> > crediting Chris Foote, you should use the "Patch by: " syntax in the
> > log message.
>
> Karl, thank you for your hint (and shame on me for not paying enough attention).
> Next Try:
>
>
> [[[
> * hot-backup.py.in
> Replace os.rmtree with our own rmtree implementation
> so that we can remove read-only files on Windows.
>
> Patch by: Chris Foote <cfoote@v21.me.uk>
> ]]]

The test suite has an implementation of rmtree as well (safe_rmtree)
that does about the same thing although it is not as careful and just
makes the entire tree writeable before removing it. It also supports
an optional retry parameter to help deal with tag-alongs (indexers,
antivirus, etc), I guess.

Any objections to just using that?

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 23 22:41:13 2007