[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: XML parsing/writing in libsvn_wc

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2007-03-22 19:12:33 CET

On 3/22/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> On Tue, Mar 20, 2007 at 04:07:34AM -0700, Karl Fogel wrote:
> > > - (This isn't exclusive to sparse-directories: changelist and keep-local
> > > do it too, but:) Why are we writing out the depth attribute in the
> > > old XML-format entries, when by definition it can never have any value
> > > other than the default? (Also note that the specification for the
> > > entries XML format prohibits unknown attributes, so this is
> > > technically wrong).
> >
> > Hmmm, good point. Undone in r23931.
> >
>
> Looking at this a little harder, I see that svn_wc__atts_to_entry() is
> also used for parsing the logs produced by svn_wc__loggy_entry_modify(),
> and so changelist, keep-local, and depth should probably all be included
> in both.
>
> However, I see that none of them are in svn_wc__loggy_entry_modify(),
> which makes me wonder how they're being updated anyway.
>
> I _think_ that 'depth' should be added back as an attribute, parsed in
> svn_wc__atts_to_entry(), _not_ added to write_xml_entry(), and somehow
> modified via svn_wc__loggy_entry_modify(). Changelist and keep-local
> also should be modified via svn_wc__loggy_entry_modify().
>
> Can someone who has a better idea how libsvn_wc works confirm whether
> I'm talking rubbish or not?
Yes, you are right. svn_wc__atts_to_entry should updated every time
when we add new fields.

We urgently need test suite for libsvn_wc! May be it could SoC task?

>
> Regards,
> Malcolm
> "Help, libsvn_wc is a big steamy mess".
>
>

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 22 19:13:11 2007

This is an archived mail posted to the Subversion Dev mailing list.