[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[sparse-directories] Default depth in reporter?

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-03-07 11:44:47 CET

Hi,

I'm taking a look at the sparse-directories branch and how the new
extensions to the reporter work.

I think I understand how the depth parameter to set_path and link_path work.
It tells the editor driver what changes we want in a particular subtree
and also that, unless paths under this subtree are reported differently, it
can assume that we already have the subpaths corresponding to the reported
depth. (Please correct me if I'm wrong).

My question then is, why do we need a default depth argument to
svn_repo_begin_report3 and the RA functions that indirectly call it?
We always start a report by a call to set_path, establishing the depth of
the target, which effectively becomes the default depth then.
So can't we just get rid of the recurse flag and have the reporter user
set the depth later on? The compatibility shim would just remember the recurse
flag and pass it along as a depth value in the first set_path call.

Am I missing something?

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 7 11:45:14 2007

This is an archived mail posted to the Subversion Dev mailing list.