Re: svn commit: r23434 - in trunk/subversion: include libsvn_client libsvn_subr

Garrett Rooney wrote:
> On 2/21/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>
>> No strong objections here. In fact, if we return an svn_error_t *,
>> which I think we should, we'd better be passing in a pool, because we
>> would need to allocate potential errors from that pool.
>
> That's incorrect. Errors are allocated within their own pool, because
> they often need to persist longer than the pool available in the
> function they are created in.

Ah, you are right. I've gotten used to seeing the pool parameter to
create the arguments for the format string to svn_error_createf().
Thanks correcting me.

-Hyrum