Re: svn commit: r23434 - in trunk/subversion: include libsvn_client libsvn_subr

On Mon, 19 Feb 2007, hwright@tigris.org wrote:
...
> --- trunk/subversion/include/svn_opt.h (original)
> +++ trunk/subversion/include/svn_opt.h Mon Feb 19 19:45:21 2007
...
> -svn_error_t *
> -svn_client__resolve_revisions(svn_opt_revision_t *peg_rev,
> - svn_opt_revision_t *op_rev,
> - svn_boolean_t is_url,
> - svn_boolean_t notice_local_mods);
...
> --- trunk/subversion/libsvn_subr/opt.c (original)
> +++ trunk/subversion/libsvn_subr/opt.c Mon Feb 19 19:45:21 2007
> @@ -610,6 +610,33 @@
> }
>
>
> +void
> +svn_opt_resolve_revisions(svn_opt_revision_t *peg_rev,
> + svn_opt_revision_t *op_rev,
> + svn_boolean_t is_url,
> + svn_boolean_t notice_local_mods)
> +{
> + if (peg_rev->kind == svn_opt_revision_unspecified)
> + {
> + if (is_url)
> + {
> + peg_rev->kind = svn_opt_revision_head;
> + }
> + else
> + {
> + if (notice_local_mods)
> + peg_rev->kind = svn_opt_revision_working;
> + else
> + peg_rev->kind = svn_opt_revision_base;
> + }
> + }
> +
> + if (op_rev->kind == svn_opt_revision_unspecified)
> + *op_rev = *peg_rev;
> +
> + return;
> +}
...

If we're really going to drop the return value of SVN_NO_ERROR (which
we actually might not want to do in case a future variation on the
implementation needs it), we should drop that return statement, too.