[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23433 - trunk/subversion/svnsync

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-02-20 00:13:15 CET

Hi Mike,

Nice change. One question:

On Mon, Feb 19, 2007 at 02:46:25PM -0800, cmpilato@tigris.org wrote:
> + /* Disallow the mixing --username/password with their --source- and
> + --sync- variants. Treat "--username FOO" as "--source-username
> + FOO --sync-username FOO"; ditto for "--password FOO". */
> + if ((username || password)
> + && (source_username || sync_username
> + || source_password || sync_password))
> + {
> + err = svn_error_create
> + (SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> + _("Cannot use --username or --password with any of "
> + "--source-username, --source-password, --sync-username, "
> + "or --sync-password.\n"));
> + return svn_cmdline_handle_exit_error(err, pool, "svnsync: ");
> + }

Is there any reason to disallow 'svnsync --username foo --source-password bar
--sync-password baz'? I think the only think you'd have to change to
allow it is this test, and possibly some of the help text.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Tue Feb 20 00:13:29 2007

This is an archived mail posted to the Subversion Dev mailing list.