[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: change_rev_prop atomicity

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-02-19 20:31:12 CET

On Sun, Feb 18, 2007 at 02:59:41PM -0500, David Glasser wrote:
> >revs-txns.c currently just contains svn_fs_fs__revision_prop,
> >svn_fs_fs__change_rev_prop, svn_fs_fs__get_txn_ids,
> >svn_fs_fs__txn_prop, and svn_fs_fs__begin_txn. The second should move
> >into fs_fs.c, for locking reasons. Is there any good reason not to
> >just move them all into fs_fs.c and eliminate revs-txns.[ch] while I'm
> >at it? It is much smaller than libsvn_fs_base's revs-txns.c.
>
> ... because if that's a reasonable decision, then I have a patch that
> does that and a second patch that adds a lock around
> svn_fs_fs__change_rev_prop that are ready to push.
>

I think that's a reasonable thing to do - and we will probably find that
there's some additional refactoring we can do after we've done that.
For example, svn_fs_fs__get_txn() can become a static function.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Mon Feb 19 20:31:34 2007

This is an archived mail posted to the Subversion Dev mailing list.