[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow clients to check out special files with unknown type

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-02-15 21:49:25 CET

Malcolm Rowe wrote:
> There's still a problem with 'status' afterwards, since it reports the
> new regular file as obstructing what it thinks should be a symlink, but
> this is the same problem that already occurs with symlinks in the
> Linux/VFAT cases - and in any case it's a better situation than we have
> now.
>
I'm not sure this is even a problem, it is a special file with bad
content so if status reports the file as obstructed then at least it can
be corrected. We might want to fix this and #2 some time before we want
to add new types of special files though.
> Issue 2692 sets out three things that we can do to fix this problem:
>
> 1. Make special files of unknown type work like symlinks on Windows.
> 2. Fix status not to assume that HAVE_SYMLINK means that all special
> files will be symlinks.
> 3. Possibly add some form of sanity checking to the client to make
> the problems above more difficult to cause.
>
> The patch attached does #1 above. I'm not promising to work on #2 or
> #3. Any comments on the approach or the patch?
>
I've tested the patch on Windows and it works fine, no issues in the
code. I did learn that dumpfiles with CRLF eol can't be loaded by
svnadmin at the same time ;)

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 15 21:49:58 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.