[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Recursion of copy_source_ops() causes stack overflow in Apache

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-02-14 10:56:15 CET

On Mon, Jan 29, 2007 at 04:24:36PM -0800, Daniel Rall wrote:
> On Mon, 29 Jan 2007, Daniel Berlin wrote:
> > Errr, why not just remove the c-stack and turn the thing into a while
> > loop using a pool-allocated stack?
>
> That seems like a reasonable way to go. This way, if we overflow,
> we're *really* out of memory (heap), instead of just out of stack
> space.

I've filed that task as issue 2715. Robin's attachment elsethread could
also be useful for working out whether we have a particularly degenerate
case, or that we've just been lucky so far. (Unfortunately, I'm a bit
busy at the moment, so I can't really spare the time to take a look).

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Wed Feb 14 10:56:39 2007

This is an archived mail posted to the Subversion Dev mailing list.