Re: svn commit: r23190 - trunk/subversion/libsvn_client

On Thu, 25 Jan 2007, Kobayashi Noritada wrote:

> Hi,
>
> > Author: dlr
> > Date: Tue Jan 23 12:49:42 2007
> > New Revision: 23190
> >
> > Log:
> > Improve error message for 'svn move'.
> >
> > * subversion/libsvn_client/copy.c
> > (setup_copy): Improve error message used when a repository -> WC
> > move is attempted.
> >
> >
> > Modified:
> > trunk/subversion/libsvn_client/copy.c
>
> > /* Disallow moves between the working copy and the repository. */
> > return svn_error_create
> > (SVN_ERR_UNSUPPORTED_FEATURE, NULL,
> > - _("No support for repos <--> working copy moves"));
> > + _("Repository to working copy moves are not supported"));
>
> The previous message and comment (and code) seems to be for WC->repos
> moves as well as for repos->WC ones, although the committed message is
> only for the latter. Should we make the message something like this?
>
> "Moves between the working copy and the repository are not supported"

Good catch, Nori. +1 on your suggested wording, please make it so.

- Dan