[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]operational logging for checkout and update should log revnum too.

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-29 09:40:14 CET

Kamesh, this seems like a fine idea. Why aren't we also doing this
for the "remote-status" case in the same area of the code in
mod_dav_svn/reports/update.c? Why aren't we doing this for any of the
other operational logging?

Example:

        if (entry_counter == 1 && entry_is_empty)
          action = apr_psprintf(resource->pool,
                                "checkout-or-export '%s' r%" SVN_REVNUM_T_FMT,
                                svn_path_uri_encode(spath, resource->pool),
                                revnum);
        else
          {
            if (text_deltas)
              action = apr_psprintf(resource->pool,
                                    "update '%s' r%" SVN_REVNUM_T_FMT,
                                    svn_path_uri_encode(spath, resource->pool),
                                    revnum);
            else
              action = apr_psprintf(resource->pool,
                                    "remote-status '%s'", <=== HERE!
                                    svn_path_uri_encode(spath,
                                                        resource->pool));
          }

  • application/pgp-signature attachment: stored
Received on Fri Dec 29 09:41:36 2006

This is an archived mail posted to the Subversion Dev mailing list.