[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r22818 - trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby

From: Madan U S <madan_at_collab.net>
Date: 2006-12-28 06:53:15 CET

> -----Original Message-----
> From: kou@tigris.org [mailto:kou@tigris.org]
> Sent: Thu 12/28/2006 11:09 AM
> To: svn@subversion.tigris.org
> Subject: svn commit: r22818 - trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby
>
> Author: kou
> Date: Wed Dec 27 21:39:50 2006
> New Revision: 22818
>
> Log:
> Use SIZEOF_LONG_LONG instead of sizeof(long long).

Please mention macro'ing of AI642NUM too in the above log summary.

>
> * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> (AOFF2NUM, AI642NUM): New macro.
> (ra_callbacks_progress_func): Use AOFF2NUM.
> (svn_swig_rb_client_blame_receiver_func): Use AI642NUM.
>
> Suggested by: Joe Swatosh
>
>
> Modified:
> trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
>
> Modified: trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c?pathrev=22818&r1=22817&r2=22818
> ==============================================================================
> --- trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c (original)
> +++ trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c Wed Dec 27 21:39:50 2006
> @@ -17,6 +17,15 @@
> #include "svn_utf.h"
>
>
> +#define AOFF2NUM(num) \
> + (sizeof(apr_off_t) == SIZEOF_LONG_LONG ? LL2NUM(num) : LONG2NUM(num))
> +
> +#if SIZEOF_LONG_LONG == 8

The current equivalent of this comparison is:
   sizeof(apr_int64_t) == sizeof(long long)

You have hardcoded 8 instead of apr_int64_t. Is this intentional? Why? If so, I think you should make a note of it in the log.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Dec 28 06:53:26 2006

This is an archived mail posted to the Subversion Dev mailing list.