[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH]ra_serf crashes on non-existent svn service

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-12-26 11:42:37 CET

Hi All,
Find the attached patch and log.

With regards
Kamesh Jayachandran

[[[

svn operation over ra_serf segfaults on non-existent svn service.
svn import -m 'aa' path_to_import \
  http://some_valid_host:port_with_no_service/svn/xyz

* subversion/libsvn_ra_serf/property.c
  (svn_ra_serf__wait_for_props):
   prop_ctx->parser_ctx may be null too. So better check it before
   dereferencing for its members.

Patch by: kameshj
]]]

Index: subversion/libsvn_ra_serf/property.c
===================================================================
--- subversion/libsvn_ra_serf/property.c (revision 22811)
+++ subversion/libsvn_ra_serf/property.c (working copy)
@@ -597,7 +597,10 @@
   svn_error_t *err;
 
   err = svn_ra_serf__context_run_wait(&prop_ctx->done, sess, pool);
- SVN_ERR(prop_ctx->parser_ctx->error);
+ if (prop_ctx->parser_ctx)
+ {
+ SVN_ERR(prop_ctx->parser_ctx->error);
+ }
   return err;
 }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 26 11:42:20 2006

This is an archived mail posted to the Subversion Dev mailing list.