[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improve the way svnserve handles the --root option

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-05 18:59:20 CET

On Tue, 05 Dec 2006, Vlad Georgescu wrote:

> On 12/5/06, Daniel Rall <dlr@collab.net> wrote:
> >On Mon, 04 Dec 2006, Vlad Georgescu wrote:
> >...
> >> 1. Checks that the path passed to --root exists and is a directory.
> >
> >Won't this cause a problem if 'svnserve' is started before a file
> >system is mounted? Do we care? (Sorry I didn't think of this
> >earlier, Vlad.)
>
> Good point. I don't think we should care though, people should just
> fix their init scripts, or whatever.

I'm okay with that.

> >> 2. Makes the --root option mandatory on Windows, because the default
> >> that we currently use ('/') only makes sense on Unix-like OS's.
> >
> >Nice! +1 to this portion of the patch for sure.
...
> Yes, Gmail seems to have an appetite for whitespace. I attached the
> patch to this email.

Committed to trunk in r22580.

 - Dan

  • application/pgp-signature attachment: stored
Received on Tue Dec 5 19:00:49 2006

This is an archived mail posted to the Subversion Dev mailing list.