Re: svn commit: r22440 - trunk/subversion/libsvn_ra_dav

On Sun, Nov 26, 2006 at 01:09:24PM -0800, djh@tigris.org wrote:
> Fix a crash bug when using automatic authentication protocols such as SSPI.
>
> Neon automatically tries some auth protocols and bumps the attempt
> count without using Subversion's callbacks, so we can't depend
> on attempt == 0 the first time we are called.
>

> * subversion/libsvn_ra_dav/session.c
> (request_auth): Don't depend on the attempt parameter being zero for
> the first auth callback we get from neon, just check the auth state itself.
>
> - if (attempt == 0)
> + if (attempt == 0 || ras->auth_iterstate == NULL)
> {
> const char *realmstring;
>

Could you add a comment explaining why we're checking both, please?

Regards,
Malcolm