[PATCH] support for progress information in ra_svn

On 9/16/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Mark Phippard wrote:
> > "Erik Huelsmann" <ehuels@gmail.com> wrote on 09/16/2006 03:03:43 AM:
> >
> >> The latest API docs are here: http://svn.collab.net/svn-doxygen/
> >>
> >> The TSVN guys could have told you that it's because of lack of support
> >> for it in the neon llibrary, because we have told them before that our
> >> libraries don't support it because our dependencies don't...
> >
> > Is that a valid excuse? You guys enhance and fix problems in APR all the
> > time, why not Neon? This is a legitimate feature that would also improve
> > the command line client.
> >
> > Also, Neon does at least have API to say the bytes transferred and it was
> > the TSVN guys that enhanced SVN to support this in the API. None of the
>
> And that's all that's required of neon. It can't do more. To get more
> detailed progress information, the Subversion library has to add that
> part. Neon only knows about transferred bytes.
>
> > SVN developers have stepped up to add equivalent support to the svn:// and
> > file:// protocols which are completely in your control.
>
> FYI: issue 901 (http://subversion.tigris.org/issues/show_bug.cgi?id=901)
> was opened four(!) years ago.
>
> > I wouldn't have even posted to this thread, but I did not really like the
> > finger-pointing. Yes, the libraries you use do not have support for this
> > feature currently, but if users do not repeatedly ask you for it, then how
> > are you ever going to know people want it?
>
> Even worse: even for new libraries this feature is ignored. Serf (a
> replacement for neon, written by Subversion developers does not provide
> such information. While I can understand that adding such a feature is a
> lot of work, I can't understand why it wasn't added for a library
> written from scratch.

Well, I took your comments to hart: before adding progress support, I
found out our network activity can't be canceled, so, last week, I
added cancellation support. I guess that's what all users expect, but
GUI users even more than others.

The attached patch should add progress support at the same basic level
as currently supported by ra_dav to ra_svn, but since our client
doesn't install a progress callback, there's no way testing it for me.

Could you test the patch with subclipse/TSVN for me please?

Thanks in advance!

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org