On Wed, 11 Oct 2006, Kamesh Jayachandran wrote:
> Daniel Rall wrote:
> >On Tue, 10 Oct 2006, Kamesh Jayachandran wrote:
> >
> >
> >>I would see it would be more useful to have the following,
> >>svn_range_create(start, end) which would have more use than this combo
> >>(svn_mergeinfo__make).
> >>
> >
> >An svn_merge_range_t only contains two field, start and end (see
> >svn_types.h). Is there really enough value in adding a constructor
> >function for such a simple data type? (We already have an
> >svn_range_dup() API).
>
> Sorry I was under the opinion each place we create 'svn_mergerange_t *'
> we have some sequence of alloc mem, set start, set end. This I thought
> could be replaced with one utility function. Unfortunately I could not
> find one :).
Current usage -- at least in libsvn_client's merging code, and some of
mergeinfo.c -- has primarily been to either stack-allocate the
svn_merge_range_t (using syntax like "r = {3, 7};"), or call
svn_merge_range_dup().
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 01:14:16 2006