Re: svn commit: r21797 - in trunk: . subversion/tests/cmdline subversion/tests/cmdline/svntest

Hi,
I could not see 'os.environ['SVN_EDITOR']' being execed anywhere in the
patch (or my eyes are not effective?)
One more comment

--- trunk/subversion/tests/cmdline/svntest/main.py (original)
+++ trunk/subversion/tests/cmdline/svntest/main.py Thu Oct 5 23:48:14 2006
@@ -114,6 +114,9 @@
 svnsync_binary = os.path.abspath('../../svnsync/svnsync' + _exe)
 svnversion_binary = os.path.abspath('../../svnversion/svnversion' + _exe)
 
+# The location of our mock svneditor script.
+svneditor_script = os.path.abspath('svneditor.py')
+

This won't work for 'VPATH' builds.
It sould look something like this
svneditor_script = os.path.join(os.path.dirname(sys.argv[0]),
'svneditor.py')
svneditor_script = os.path.abspath(svneditor_script)

With this commit prop_tests:1 fails in trunk.
With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 7 06:45:39 2006